Re: alter check constraint enforceability

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>
Cc: Amul Sul <sulamul(at)gmail(dot)com>, Robert Treat <rob(at)xzilla(dot)net>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: alter check constraint enforceability
Date: 2026-02-21 14:42:59
Message-ID: CACJufxHRbDMT6Ge=myw0KL2Bz_rkf+fGnLg174qTuiaLaje55w@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Feb 11, 2026 at 3:37 AM Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> wrote:
>
> Hello
>
> - if (cmdcon->alterEnforceability &&
> - ATExecAlterFKConstrEnforceability(wqueue, cmdcon, conrel, tgrel,
> - currcon->conrelid, currcon->confrelid,
> - contuple, lockmode, InvalidOid,
> - InvalidOid, InvalidOid, InvalidOid))
> + if (cmdcon->alterEnforceability)
> + {
> + if (currcon->contype == CONSTRAINT_FOREIGN)
> + ATExecAlterFKConstrEnforceability(wqueue, cmdcon, conrel, tgrel,
> + currcon->conrelid,
> + currcon->confrelid,
> + contuple, lockmode,
> + InvalidOid, InvalidOid,
> + InvalidOid, InvalidOid);
> + else if (currcon->contype == CONSTRAINT_CHECK)
> + ATExecAlterCheckConstrEnforceability(wqueue, cmdcon, conrel,
> + contuple, recurse, false,
> + lockmode);
> changed = true;
>
> Isn't this a behavior change?
>
Hi.
You are right, I missed this minor detail.
Now, I changed it to

+ if (cmdcon->alterEnforceability)
+ {
+ if (currcon->contype == CONSTRAINT_FOREIGN)
+ changed = ATExecAlterFKConstrEnforceability(wqueue,
cmdcon, conrel, tgrel,
+ currcon->conrelid,
+ currcon->confrelid,
+ contuple, lockmode,
+ InvalidOid, InvalidOid,
+ InvalidOid,
InvalidOid);
+ else if (currcon->contype == CONSTRAINT_CHECK)
+ changed = ATExecAlterCheckConstrEnforceability(wqueue,
cmdcon, conrel,
+ contuple,
recurse, false,
+ lockmode);
+ }

--
jian
https://www.enterprisedb.com/

Attachment Content-Type Size
v7-0001-rename-alter-constraint-enforceability-related-functions.patch text/x-patch 10.2 KB
v7-0002-Add-support-for-altering-CHECK-constraint-enforceability.patch text/x-patch 24.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Maxim Orlov 2026-02-21 14:59:21 Re: POC: make mxidoff 64 bits
Previous Message Henrik TJ 2026-02-21 14:27:15 Fix memory leak in postmasterMain