Re: misleading error message in DefineIndex

On Mon, Nov 17, 2025 at 8:52 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> Some of the internals does seem bleed through. Do you want to work on a patch
> for a suggestion on an improvement? Maybe it could be possible to improve the
> wording by incorporating constraint_type in some way?
>

I have changed this ereport:

ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
errmsg("unique constraint on partitioned table must include
all partitioning columns"),
errdetail("%s constraint on table \"%s\" lacks column \"%s\"
which is part of the partition key.",
constraint_type, RelationGetRelationName(rel),
NameStr(att->attname))));

to
+ errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
+ errmsg("%s constraint on partitioned table
must include all partitioning columns", constraint_type),
+ errdetail("%s constraint on partitioned table
\"%s\" lacks column \"%s\" which is part of the partition key.",
+ constraint_type,
RelationGetRelationName(rel),
+ NameStr(att->attname)));