Re: BUG #18923: pg_dump 18beta1 fails to process complex table names

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: phb(dot)emaj(at)free(dot)fr, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #18923: pg_dump 18beta1 fails to process complex table names
Date: 2025-05-13 11:34:51
Message-ID: CACJufxFLUsXw2tsTLLvWSeO0cX=Wp+fnL-vKK7eiVu0=GSSnRA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Mon, May 12, 2025 at 9:51 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> PG Bug reporting form <noreply(at)postgresql(dot)org> writes:
> > I have just run the E-Maj project regression test suite with PG18 beta1 and
> > found a pg_dump abort when trying to dump a schema prefixed table having a
> > complex name including single quote, double quote and space.
>
> Thanks for the report! Looks like fetchAttributeStats() is completely
> misguided about the appropriate quoting rules for array elements.
>

re-read ReadArrayToken.
In this context, we need to care about single-quote, double-quotes.
for backslash, we skip it.

appendPGArray can help us handle double quotes,
now we just need to make it also handle single quotes.

Attachment Content-Type Size
v1-0001-ensure-fetchAttributeStats-subroutine-handle-single-quote.patch text/x-patch 2.6 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Zane Duffield 2025-05-13 11:38:02 Re: Dependency on ccache in postgresql17-devel-17.5-1PGDG.rhel9
Previous Message Devrim Gündüz 2025-05-13 08:59:49 Re: Dependency on ccache in postgresql17-devel-17.5-1PGDG.rhel9