| From: | Maxim Orlov <orlovmg(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, ls7777 <ls7777(at)yandex(dot)ru>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch for migration of the pg_commit_ts directory |
| Date: | 2025-10-06 07:58:55 |
| Message-ID: | CACG=ezaFdL4EM8bdrHTRVHt5BmxxWGXcPiDr6Qm00Qj+S_Y+vQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 2 Oct 2025 at 11:49, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> When we try to
> copy slots and the wal_level on the new server is minimal, we error
> out, so shouldn't we do the same here and error_out if
> track_commit_timestamp is not enabled and we have some valid commit_ts
> data to copy?
>
+1 Sounds reasonable to me. It's better to give an explicit error;
otherwise, we would remove data that the user clearly wants to migrate
to the new cluster. And deleting data just because the user forgot to
specify one parameter in a new cluster looks like a bad joke to me.
--
Best regards,
Maxim Orlov.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2025-10-06 08:22:11 | Re: Should we update the random_page_cost default value? |
| Previous Message | Michael Paquier | 2025-10-06 07:28:12 | Re: Remove custom redundant full page write description from GIN |