Re: should frontend tools use syncfs() ?

From: Maxim Orlov <orlovmg(at)gmail(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Paul Guo <guopa(at)vmware(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Brown <michael(dot)brown(at)discourse(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: should frontend tools use syncfs() ?
Date: 2023-09-21 08:29:48
Message-ID: CACG=ezYqivQrgeSeP8xQao1RXLgVJrwaoyzEbCgsixGy8wLB3w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 20 Sept 2023 at 22:08, Nathan Bossart <nathandbossart(at)gmail(dot)com>
wrote:

> I think we should also consider renaming things like SYNC_METHOD_FSYNC to
> WAL_SYNC_METHOD_FSYNC, and sync_method_options to wal_sync_method_options.
>

I've already rename sync_method_options in previous patch.
34 @@ -171,7 +171,7 @@ static bool check_wal_consistency_checking_deferred
= false;
35 /*
36 * GUC support
37 */
38 -const struct config_enum_entry sync_method_options[] = {
39 +const struct config_enum_entry wal_sync_method_options[] = {

As for SYNC_METHOD_FSYNC rename, PFA patch.
Also make enum for WAL sync methods instead of defines.

--
Best regards,
Maxim Orlov.

Attachment Content-Type Size
v11-0001-Fix-conflicting-types-for-sync_method.patch application/octet-stream 10.6 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2023-09-21 08:32:01 Re: remaining sql/json patches
Previous Message Amit Kapila 2023-09-21 08:22:34 Re: New WAL record to detect the checkpoint redo location