Re: Add 64-bit XIDs into PostgreSQL 15

From: Maxim Orlov <orlovmg(at)gmail(dot)com>
To: Thom Brown <thom(at)linux(dot)com>
Cc: Zhang Mingli <zmlpostgres(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Stephen Frost <sfrost(at)snowman(dot)net>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Ilya Anfimov <ilan(at)tzirechnoy(dot)com>
Subject: Re: Add 64-bit XIDs into PostgreSQL 15
Date: 2022-11-14 13:56:07
Message-ID: CACG=ezYiRfkNb3dTqeThebRL3mVfMm65hqaXOuk=FOGB_HbgQg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>
>
> 0008 needs a rebase. heapam.h and catversion.h are failing.
>
> Regards
>
> Thom
>

Thanks, done!

Also add copying of the xmin and xmax while page is locked. In heapgetpage
we have to copy tuples xmin and xmax while
we're holding a lock. Since we do not hold a lock after that, values of
xmin or xmax may be changed, and we may get
incorrect values of those fields. This affects only the scenario when the
user select xmin or xmax "directly" by SQL query, AFAICS.

--
Best regards,
Maxim Orlov.

Attachment Content-Type Size
v50-0004-Use-64-bit-pages-representation-in-SLRU-callers.patch application/octet-stream 23.6 KB
v50-0001-Use-64-bit-numbering-of-SLRU-pages.patch application/octet-stream 24.5 KB
v50-0005-Add-initdb-option-to-initialize-cluster-with-non.patch application/octet-stream 24.3 KB
v50-0003-Use-64-bit-FullTransactionId-instead-of-Epoch-xi.patch application/octet-stream 18.7 KB
v50-0002-Use-64-bit-format-to-output-XIDs.patch application/octet-stream 123.1 KB
v50-0007-Use-64-bit-GUCs.patch application/octet-stream 25.7 KB
v50-0006-README.XID64.patch application/octet-stream 7.2 KB
v50-0008-Use-64-bit-XIDs.patch application/octet-stream 756.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-11-14 14:23:54 Re: pg_basebackup's --gzip switch misbehaves
Previous Message Daniel Verite 2022-11-14 13:47:35 Re: psql: Add command to use extended query protocol