| From: | Maxim Orlov <orlovmg(at)gmail(dot)com> |
|---|---|
| To: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
| Cc: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Japin Li <japinli(at)hotmail(dot)com>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Ilya Anfimov <ilan(at)tzirechnoy(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Subject: | Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15) |
| Date: | 2022-03-22 11:54:56 |
| Message-ID: | CACG=ezYV3FM5i9ws2QLyF+rz5WHTqheL59VRsHGsgAwfx8gh4g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi!
Here is v23. As was suggested by Alexander above, I've changed the order of
the patches and improved the commit message. Now, SLRU patch is the first.
Splitting 64 bit XIDs into a bunch of patches was done to simplify
reviewing and making commits in small portions. We have little overhead
here like removing Epoch later and now changes are based on the fact that
Epoch still exists.
In the SLRU patch we have changed SLRU page numbering from int to int64.
There were proposals to make use of SLRU pages numbers that are in fact
unsigned and change from int to uint64. I fully support this, but I'm not
sure this big SLRU refactoring should be done in this patchset. On the
other hand it seems logical to change everything in SLRU at once. I think I
need a second opinion in support of this change.
In general, I consider this patchset is ready to commit. It would be great
to deliver it in PG15.
--
Best regards,
Maxim Orlov.
| Attachment | Content-Type | Size |
|---|---|---|
| v23-0001-Use-64-bit-numbering-of-SLRU-pages.patch | application/octet-stream | 25.6 KB |
| v23-0002-Use-64-bit-format-to-output-XIDs.patch | application/octet-stream | 117.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michail Nikolaev | 2022-03-22 12:07:54 | Re: Patch proposal - parameter to limit amount of FPW because of hint bits per second |
| Previous Message | Amit Kapila | 2022-03-22 11:50:05 | Re: logical replication empty transactions |