| From: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: WIN32 pg_import_system_collations |
| Date: | 2022-11-10 10:08:32 |
| Message-ID: | CAC+AXB3Wx3CH-1OBEg_1uWcAOzYQ-S+B3_c0emhmgejgen7iNw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 9, 2022 at 12:02 AM Juan José Santamaría Flecha <
juanjo(dot)santamaria(at)gmail(dot)com> wrote:
> On Mon, Nov 7, 2022 at 4:08 PM Peter Eisentraut <
> peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
>
>>
>> This looks pretty good to me. The refactoring of the non-Windows parts
>> makes sense. The Windows parts look reasonable on manual inspection,
>> but again, I don't have access to Windows here, so someone else should
>> also look it over.
>>
>> I was going to say that at least it is getting tested on the CI, but I
> have found out that meson changes version(). That is fixed in this version.
>
Now is currently failing due to [1], so maybe we can leave this patch on
hold until that's addressed.
Regards,
Juan José Santamaría Flecha
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2022-11-10 10:13:54 | Re: Making Vars outer-join aware |
| Previous Message | Juan José Santamaría Flecha | 2022-11-10 09:59:41 | Meson doesn't define HAVE_LOCALE_T for mscv |