| From: | David Bidoc <dcbidoc(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Guillaume Lelarge <guillaume(dot)lelarge(at)dalibo(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: oid2name : add objects file path |
| Date: | 2025-12-15 14:30:53 |
| Message-ID: | CABour1tWqUQU0VtDRbhTy2hbMdOg0u15cb1vD=ZtRT-oAFMz8g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Michael
On Thu, Dec 4, 2025 at 1:46 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Tue, Dec 02, 2025 at 11:36:39AM +0100, David Bidoc wrote:
> > I attached the rebased patch.
> > Any feedback would be appreciated.
>
> Your patch still fails to apply on HEAD for all the changes of
> contrib/oid2name/oid2name.c. Please see the following:
> https://commitfest.postgresql.org/patch/6111/
>
Thank you for your feedback.
I attached the rebased and updated patch.
> It also seems like Euler's feedback has not been answered. I am
> pretty sure that he was referring about the addition of an example in
> the documentation, or at least refreshing the areas of the docs that
> are impacted with your change (no clear idea about all that without a
> rebased patch).
I updated the documentation example about the -x option :
$ # you can mix the options, and get more details with -x
$ oid2name -d alvherre -t accounts -f 1155291 -x
From database "alvherre":
Filenode Table Name Oid Schema Tablespace Filepath
--------------------------------------------------------------------------
155173 accounts 155173 public pg_default base/17228/155173
1155291 accounts_pkey 1155291 public pg_default base/17228/1155291
I modified the example already used to maintain consistency.
--
David Bidoc
| Attachment | Content-Type | Size |
|---|---|---|
| oid2name_filepathv4.patch | text/x-patch | 2.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2025-12-15 14:31:13 | Re: POC: make mxidoff 64 bits |
| Previous Message | Alvaro Herrera | 2025-12-15 14:25:22 | Re: Adding REPACK [concurrently] |