| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: auto_explain sample rate |
| Date: | 2016-03-13 12:21:14 |
| Message-ID: | CABUevEzTR2twjHEQvP_xV+oD_9odwVDsAd2zSb0YKo-cVma21g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Mar 12, 2016 at 3:20 PM, Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>
wrote:
> On 11/03/2016 17:55, Robert Haas wrote:
> > On Fri, Mar 11, 2016 at 11:33 AM, Tomas Vondra
> > <tomas(dot)vondra(at)2ndquadrant(dot)com> wrote:
> >> A bit late, but I think we should rename the GUC variable to
> >> "sampling_rate" (instead of sample_ratio) as that's what pgbench uses
> >> for the same thing. That'd be more consistent.
> >
> > I like that idea. It seems like slightly better terminology.
> >
>
> I like it too. I also just noticed that I duplicated the var type by
> mistake in the documentation :/
>
> Attached patch fixes both.
>
>
I also agree, and thanks for doing the work :) Applied!
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Stark | 2016-03-13 12:32:23 | Re: [GENERAL] OS X 10.11.3, psql, bus error 10, 9.5.1 |
| Previous Message | Magnus Hagander | 2016-03-13 12:12:16 | Re: Refectoring of receivelog.c |