Re: Online checksums patch - once again

On Mon, Sep 30, 2019 at 6:11 PM Andres Freund <andres(at)anarazel(dot)de> wrote:

> Hi,
>
> On 2019-09-30 16:59:00 +0200, Magnus Hagander wrote:
> > On Mon, Sep 30, 2019 at 2:49 PM Tomas Vondra <
> tomas(dot)vondra(at)2ndquadrant(dot)com>
> > wrote:
> > > IMHO the patch is ready to go - I think the global barrier solves the
> > > issue in the previous version, and that's the only problem I'm aware
> of.
> > > So +1 from me to go ahead and push it.
>
> I don't think the global barrier part is necessarily ready. I wrote it
> on a flight back from a conference, to allow Magnus to make some
> progress. And I don't think it has received meaningful review so far.
>

I don't believe it has, no. I wouldn't trust my own level of review a
tleast :)

> Especially -- Andres, any chance I can bribe you to take another look?
>
> I'll try to take a look.
>

Much appreciated!

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>