Re: 1.16 beta 1 ?

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: 1.16 beta 1 ?
Date: 2012-05-07 08:32:32
Message-ID: CABUevExgg006LLkZpn6__9Hu9MrEifLNEGLAa1hGJLot3BSYdA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Mon, May 7, 2012 at 10:29 AM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> On Mon, 2012-05-07 at 09:11 +0100, Dave Page wrote:
>>
>>
>> On Monday, May 7, 2012, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> > Given that it's self contained, and we *do* expect it to get in
>> > eventually, how many places would you have to put #ifdef's in to
>> leave
>> > the code in the main branch and just not have it build there?
>>
>
> Not much. It would be quite easy to do.

Then I suggest that path.

>> If Guillaume is going to continue to work on the feature, I'd be happy
>> with #ifdef's and a configure switch to enable that code.
>>
>
> I want to continue the work on it. But to be completely honest, it isn't
> my priority. My priority is to get new releases of pgAdmin with the
> biggest support of the new PostgreSQL features.

That seems like reasonable priorities. But if it were to decent to the
point of being basically "dead code", it shuld be removed.

> I'll work on a patch with the ifdef's. It'll be much less work.

Good.

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2012-05-07 10:33:08 Re: Re: PATCH: The linker complains about the '-bundle_loader "../../src/backend/postgres"' against PostgreSQL 8.4 on OSX
Previous Message Guillaume Lelarge 2012-05-07 08:29:16 Re: 1.16 beta 1 ?