Re: pg_basebackup with -R option and start standby have problems with escaped password

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Hari Babu <haribabu(dot)kommi(at)huawei(dot)com>, zb <zb(at)cybertec(dot)at>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_basebackup with -R option and start standby have problems with escaped password
Date: 2013-01-29 10:15:41
Message-ID: CABUevExc66K16r1yoAzuM5Gyqfh8NNHgUpHu1jMsKy8ZkBD-ww@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jan 24, 2013 at 7:04 AM, Hari Babu <haribabu(dot)kommi(at)huawei(dot)com> wrote:
> On Wed, Jan 23, 2013 11:48 PM, Magnus Hagander wrote:
>>On Wed, Jan 23, 2013 at 10:18 AM, Hari Babu <haribabu(dot)kommi(at)huawei(dot)com>
> wrote:
>>> Test scenario to reproduce:
>>> 1. Start the server
>>> 2. create the user as follows
>>> ./psql postgres -c "create user user1 superuser login
>>> password 'use''1'"
>>>
>>> 3. Take the backup with -R option as follows.
>>> ./pg_basebackup -D ../../data1 -R -U user1 -W
>>>
>>> The following errors are occurring when the new standby on the backup
>>> database starts.
>>>
>>> FATAL: could not connect to the primary server: missing "=" after "1'"
> in
>>> connection info string
>>
>>What does the resulting recovery.conf file look like?
>
> The recovery.conf which is generated is as follows
>
> standby_mode = 'on'
> primary_conninfo = 'user=''user1'' password=''use''1'' port=''5432'' '
>
>
> I observed the problem is while reading primary_conninfo from the
> recovery.conf file
> the function "GUC_scanstr" removes the quotes of the string and also makes
> the
> continuos double quote('') as single quote(').
>
> By using the same connection string while connecting to primary server the
> function "conninfo_parse" the escape quotes are not able to parse properly
> and it is leading
> to problem.
>
> please correct me if any thing wrong in my observation.

Well, it's clearly broken at least :O

Zoltan, do you have time to look at it? I won't have time until at
least after FOSDEM, unfortunately.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2013-01-29 10:22:43 Re: Performance Improvement by reducing WAL for Update Operation
Previous Message Heikki Linnakangas 2013-01-29 10:12:41 Re: [PERFORM] pgbench to the MAXINT