From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | NISHIYAMA Tomoaki <tomoakin(at)staff(dot)kanazawa-u(dot)ac(dot)jp> |
Cc: | pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net> |
Subject: | Re: [PATCH] PostgreSQL fails to build with 32bit MinGW-w64 |
Date: | 2011-12-03 14:59:46 |
Message-ID: | CABUevEwqe0Fxu5c+PhKA+XQBZ3d-G=f+rq2j59D6DQ3EhNU5XQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Dec 3, 2011 at 15:49, NISHIYAMA Tomoaki
<tomoakin(at)staff(dot)kanazawa-u(dot)ac(dot)jp> wrote:
> Hi,
>
>> Have you verified if tihs affects _MSC_VER < 1400? Suddently that
>> branch would care about HAVE_CRTDEFS_H, and I'm not sure if that's
>> something we need to worry about.
>
>
> I have no MSVC. In that sense it is not verified in fact, and I hope
> those who knows well would kindly comment on it.
>
> However, it appears that pg_config.h is not created through
> configure, but just copied from pg_config.h.win32 in those
> compilers and thus HAVE_CRTDEFS_H will not be defined.
> So, I think this code fragment will not be enabled in
> _MSC_VER < 1400
Hmm, true. Unless HAVE_CRTDEFS_H is defined by the sytem, which it
likely isn't - I was confusing it with the kind of defines that MSVC
tends to stick in their own headerfiles, and thought that's what you
were testing for.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2011-12-03 16:04:02 | Re: backup_label during crash recovery: do we know how to solve it? |
Previous Message | Tomas Vondra | 2011-12-03 14:56:46 | why local_preload_libraries does require a separate directory ? |