| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | pg_upgrade analyze script |
| Date: | 2020-10-06 09:43:01 |
| Message-ID: | CABUevEwg5LDFzthhxzSj7sZGMiVsZe0VVNbzzwTQOHJ=rN7+5A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
For a long time now, pg_upgrade drops a script (analyze_new_cluster.sh)
that just calls vacuumdb to run the analyze in stages. This script made a
lot of sense back when it actually implemented the stages, but these days
since it's just calling a single command, I think it's just unnecessary
complication.
I suggest we drop it and just replace it with instructions to call vacuumdb
directly.
Attached patch does this. It also removes the support in the instructions
that talk about pre-8.4 databases, which I believe is dead code per
https://postgr.es/m/CABUevEx-D0PNVe00tkeQRGennZQwDtBJn=
493MJt-x6sppbUxA(at)mail(dot)gmail(dot)com(dot)
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
| Attachment | Content-Type | Size |
|---|---|---|
| pg_upgrade_analyze.patch | text/x-patch | 8.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2020-10-06 10:10:16 | Re: Parallel INSERT (INTO ... SELECT ...) |
| Previous Message | Daniel Gustafsson | 2020-10-06 09:40:57 | Re: pg_upgrade dead code for pre-8.4 versions |