Re: BUG #19600: pgcrypto crypt() can return text with invalid encoding

ср, 28 окт. 2026 г. в 14:09, Ishjaap Singh <ishjaap(dot)singh07(at)gmail(dot)com>:

> Two points:
>
> 1. Hashes already stored with invalid encoding stop working after the
> upgrade: crypt(pw, stored_hash) now raises an error instead of
> returning a hash to compare, for the right password as well as a
> wrong one. That seems acceptable to me, since the stored value
> already can't be dumped and restored, and it's a similar trade-off
> to the one the PGP decrypt functions made in d536aee5566, although
> unlike those, crypt() has no bytea variant to fall back on. It may
> be worth a mention in the release notes.
>
> 2. The new test covers only DES. Since the fix handles xDES and MD5 as
> well, it might be worth adding those cases from the report.
>
>
Hi, Ishjaap!

Thanks for the review.

I've updated the commit message and added the test cases for item 2.

--
Regards,
Rachitskiy Andrey