Re: [PATCH] Expand character set for ltree labels

From: Ian Lawrence Barwick <barwick(at)gmail(dot)com>
To: Garen Torikian <gjtorikian(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Expand character set for ltree labels
Date: 2022-11-03 23:37:09
Message-ID: CAB8KJ=jjHdKmHrrSCfr4n4MQEZ2en5K+5V6wLnXod6x58NR5Lw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2022年10月6日(木) 7:05 Garen Torikian <gjtorikian(at)gmail(dot)com>:
>
> After digging into it, you are completely correct. I had to do a bit more reading to understand the relationships between UTF-8 and wchar, but ultimately the existing locale support works for my use case.
>
> Therefore I have updated the patch with three much smaller changes:
>
> * Support for `-` in addition to `_`
> * Expanding the limit to 512 chars (from the existing 256); again it's not uncommon for non-English strings to be much longer
> * Fixed the documentation to expand on what the ltree label's relationship to the DB locale is
>
> Thank you,
> Garen

This entry was marked as "Needs review" in the CommitFest app but cfbot
reports the patch no longer applies.

We've marked it as "Waiting on Author". As CommitFest 2022-11 is
currently underway, this would be an excellent time update the patch.

Once you think the patchset is ready for review again, you (or any
interested party) can move the patch entry forward by visiting

https://commitfest.postgresql.org/40/3929/

and changing the status to "Needs review".

Thanks

Ian Barwick

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jacob Champion 2022-11-03 23:39:17 Re: [PATCH] Add `verify-system` sslmode to use system CA pool for server cert
Previous Message Ian Lawrence Barwick 2022-11-03 23:34:43 Re: Data is copied twice when specifying both child and parent table in publication