Re: increasing the default WAL segment size

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Beena Emerson <memissemerson(at)gmail(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: increasing the default WAL segment size
Date: 2017-01-27 01:53:44
Message-ID: CAB7nPqTn_yuFwpK+qHJswP1bG_KbE68=jY-w6i7sLVyS+yDYbg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Fri, Jan 27, 2017 at 4:20 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2017-01-25 12:26:21 +0900, Michael Paquier wrote:
>> diff --git a/src/backend/access/common/tupdesc.c b/src/backend/access/common/tupdesc.c
>> index 083c0303dc..2eb3a420ac 100644
>> --- a/src/backend/access/common/tupdesc.c
>> +++ b/src/backend/access/common/tupdesc.c
>> @@ -629,6 +629,14 @@ TupleDescInitBuiltinEntry(TupleDesc desc,
>> att->attstorage = 'p';
>> att->attcollation = InvalidOid;
>> break;
>> +
>> + case INT8OID:
>> + att->attlen = 8;
>> + att->attbyval = true;
>> + att->attalign = 'd';
>> + att->attstorage = 'p';
>> + att->attcollation = InvalidOid;
>> + break;
>> }
>> }
>
> INT8 isn't unconditionally byval, is it?

Doh. Of course.

>> /* slot_name */
>> - len = strlen(NameStr(MyReplicationSlot->data.name));
>> - pq_sendint(&buf, len, 4); /* col1 len */
>> - pq_sendbytes(&buf, NameStr(MyReplicationSlot->data.name), len);
>> + values[0] = PointerGetDatum(cstring_to_text(NameStr(MyReplicationSlot->data.name)));
>
> That seems a bit long.

Sure. What about that:
- len = strlen(NameStr(MyReplicationSlot->data.name));
- pq_sendint(&buf, len, 4); /* col1 len */
- pq_sendbytes(&buf, NameStr(MyReplicationSlot->data.name), len);
+ slot_name = NameStr(MyReplicationSlot->data.name);
+ values[0] = PointerGetDatum(cstring_to_text(slot_name));

> I've not done like the most careful review ever, but I'm in favor of the
> general change (provided the byval thing is fixed obviously).

Thanks for the review.
--
Michael

Attachment Content-Type Size
refactor-repl-cmd-output-v2.patch application/octet-stream 11.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2017-01-27 02:13:23 Re: Parallel Index Scans
Previous Message Michael Paquier 2017-01-27 01:35:17 Re: Allow interrupts on waiting standby