| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Asif Naeem <anaeem(dot)it(at)gmail(dot)com> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Andreas Karlsson <andreas(at)proxel(dot)se>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgcrypto compilation error due to stack-allocated EVP_CIPHER_CTX |
| Date: | 2016-12-06 13:15:19 |
| Message-ID: | CAB7nPqTbVOy7_Wuw8uD62fWp1RGHN7fDqkRg8s5jLHRAjGMvyw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Dec 6, 2016 at 9:31 PM, Asif Naeem <anaeem(dot)it(at)gmail(dot)com> wrote:
> Thank you for v2 patch, I would like to comment on it. It seems that you
> have used function EVP_CIPHER_CTX_reset in the patch that was introduced in
> OpenSSL 1.1.0, older library version might not work now, is it intentional
> change ?.
I thought I tested that... But yes, that would not compile when linked
with 1.0.2 or older. Using EVP_CIPHER_CTX_cleanup() is safe instead as
that's available down to 0.9.8.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| pgcrypto-openssl11-fix-v3.patch | application/x-download | 6.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Rahila Syed | 2016-12-06 13:42:36 | Re: Assignment of valid collation for SET operations on queries with UNKNOWN types. |
| Previous Message | Robert Haas | 2016-12-06 12:50:30 | Re: PSQL commands: \quit_if, \quit_unless |