Re: [HACKERS] Creating backup history files for backups taken from standbys

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: David Steele <david(at)pgmasters(dot)net>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: [HACKERS] Creating backup history files for backups taken from standbys
Date: 2018-01-06 08:48:24
Message-ID: CAB7nPqTL+LSE1A0t6HyRh_v4YOEcUmM8ZWT+grD9pYmcL9NhXA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Fri, Jan 5, 2018 at 11:27 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> I'm not.
>
> If we want to do this why not only do it in the modes that have meaning?
> i.e. put an if() test in for archive_mode == always.

OK, I can see value in your point as well. The check is a bit more
complicated that just looking for archive_mode == always though, you
need to look at if the backup has been started in recovery or not, and
then adapt using XLogArchivingActive() and XLogArchivingAlways(),
similarly to what is done when waiting for the archives.

> Which also makes it a smaller and clearer patch

Yes, this generates less diffs, reducing the likelihood of bugs. What
do you think about the v3 attached?
--
Michael

Attachment Content-Type Size
standby-backup-history-v3.patch application/octet-stream 3.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2018-01-06 10:08:10 Re: [HACKERS] Removing useless DISTINCT clauses
Previous Message Pavel Stehule 2018-01-06 06:22:03 Re: [HACKERS] SQL/JSON in PostgreSQL