| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Implementing pg_receivewal --no-sync |
| Date: | 2017-10-28 22:12:23 |
| Message-ID: | CAB7nPqTDwNbnpZfZ=xxe=J9bQCLqsK+LFTuWa9OA25Q4zSG6SA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 27, 2017 at 12:03 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Thu, Oct 26, 2017 at 10:46 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Wed, Oct 25, 2017 at 10:03 PM, Michael Paquier
>> <michael(dot)paquier(at)gmail(dot)com> wrote:
>>> This sentence is actually wrong, a feedback message is never sent with
>>> the feedback message.
>>
>> Eh?
>
> "A feedback message is never sent depending on the status interval".
>
>> I think this looks basically fine, though I'd omit the short option
>> for it. There are only so many letters in the alphabet, so let's not
>> use them up for developer-convenience options.
>
> No objections to that.
Okay. Here is an updated patch incorporating those comments.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| pg_receivewal_nosync_v3.patch | application/octet-stream | 4.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2017-10-28 22:30:12 | Re: CUBE seems a bit confused about ORDER BY |
| Previous Message | Pavel Stehule | 2017-10-28 21:47:27 | Re: Re: proposal - psql: possibility to specify sort for describe commands, when size is printed |