| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Refactoring of replication commands using printsimple |
| Date: | 2017-02-01 01:26:06 |
| Message-ID: | CAB7nPqT2K4XFT1JgqufFBjsOc-NUKXg5qBDucHPMbk6Xi1kYaA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 31, 2017 at 11:59 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> Sorry, I have a little more nitpicking.
Thanks for the input.
> How about having
> printsimple() use pq_sendcountedtext() instead of pq_sendint()
> followed by pq_sendbytes(), as it does for TEXTOID?
>
> Other than that, this looks fine to me now.
pq_sendcountedtext() does some encoding conversion, which is why I
haven't used because we deal only with integers in this patch... Now
if you wish to switch to that I have really no arguments against.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| refactor-repl-cmd-output-v4.patch | application/octet-stream | 11.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-02-01 02:05:19 | Re: logical decoding of two-phase transactions |
| Previous Message | Michael Paquier | 2017-02-01 01:02:19 | Re: sequence data type |