Re: PQexec() hangs on OOM

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Oleksandr Shulgin <oleksandr(dot)shulgin(at)zalando(dot)de>
Cc: hlinnaka(at)iki(dot)fi, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: PQexec() hangs on OOM
Date: 2015-05-26 07:01:26
Message-ID: CAB7nPqT1TVnaKgfoXE7fgKhvL6-ibDWTj1BQT3TjEgp60_cH0A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-bugs

On Thu, May 21, 2015 at 1:31 AM, Oleksandr Shulgin wrote:
> Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
>> So, attached is take three for all the other things above.
>
> There's still one call to pqGetErrorNotice3 that doesn't check returned
> value for -2, in fe-connect.c. Shouldn't we also check it like this:
>
> [...]

Yes, you are right. Take 4 attached is updated with something similar
to what you sent to cover this code path.
--
Michael

Attachment Content-Type Size
0001-Improve-OOM-detection-of-parseInput-in-libpq.patch text/x-diff 41.8 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message abdul aziz zulfikar 2015-05-26 12:21:11
Previous Message Stephen Frost 2015-05-26 02:02:43 Re: Incorrect processing of CREATE TRANSFORM with DDL deparding