Skip site navigation (1) Skip section navigation (2)

Re: Enforce creation of destination folders for source files in pg_regress (Was: pg_regress writes into source tree)

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Enforce creation of destination folders for source files in pg_regress (Was: pg_regress writes into source tree)
Date: 2015-02-23 06:27:03
Message-ID: CAB7nPqT-00fQ1qfumVskFp9PoH0+hsY4DSxejjr37SkwBAgEFw@mail.gmail.com (view raw, whole thread or download thread mbox)
Thread:
Lists: pgsql-hackers
On Mon, Feb 23, 2015 at 12:00 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> On 2/22/15 5:41 AM, Michael Paquier wrote:
>>> You could argue that these .gitignore files don't actually belong there,
>>> but your patch doesn't change or move those files, and even modules that
>>> have non-empty sql/ or expected/ directories have .gitignore files
>>> there, so it is considered the appropriate location.
>>
>> This is up to the maintainer of each extension to manage their code
>> tree. However I can imagine that some people would be grateful if we
>> allow them to not need sql/ and expected/ containing only one single
>> .gitignore file ignoring everything with "*", making the code tree of
>> their extensions cleaner.
>
> I would like to have an extension in tree that also does this, so we
> have a regression test of this functionality.

Sure. Here is one in the patch attached added as a test module. The
name of the module is regress_dynamic. Perhaps the name could be
better..
-- 
Michael

Attachment: 0001-Enforce-creation-of-input-and-output-paths-in-pg_reg.patch
Description: text/x-diff (2.0 KB)
Attachment: 0002-Add-regress_dynamic-as-a-test-module.patch
Description: text/x-diff (4.6 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Michael PaquierDate: 2015-02-23 06:33:38
Subject: Re: Expanding the use of FLEXIBLE_ARRAY_MEMBER for declarations like foo[1]
Previous:From: Corey HuinkerDate: 2015-02-23 06:26:55
Subject: Re: dblink: add polymorphic functions.

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group