| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Fabrízio Mello <fabriziomello(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Payal Singh <payal(at)omniti(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add CINE for ALTER TABLE ... ADD COLUMN |
| Date: | 2015-07-23 04:30:49 |
| Message-ID: | CAB7nPqSfNK96n6VnMij7aLkU2ntpXEhk987zucGy-nn_T9kzKQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 23, 2015 at 9:55 AM, Fabrízio de Royes Mello wrote:
> Thank you for the review.
+ /* skipp if the name already exists and if_not_exists is true */
s/skipp/skip.
Except that this looks in good shape to me (see attached for a version
fixing the typo) so switched to "Ready for committer".
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| alter-table-add-column-if-not-exists_v6.patch | text/x-patch | 13.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2015-07-23 04:50:37 | Re: A little RLS oversight? |
| Previous Message | Kouhei Kaigai | 2015-07-23 04:26:06 | Re: Queries runs slow on GPU with PG-Strom |