| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
| Cc: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Marko Tiikkaja <marko(at)joh(dot)to>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much |
| Date: | 2017-10-19 15:25:45 |
| Message-ID: | CAB7nPqSf0jMiCpJcsQSg6s3xLiLry3WaqeKOviYA7XfFu6QCzQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Thu, Oct 19, 2017 at 10:13 PM, Andrew Dunstan
<andrew(dot)dunstan(at)2ndquadrant(dot)com> wrote:
>
>
> On 10/18/2017 10:07 PM, Michael Paquier wrote:
>> Please see the attached patch which considers all the discussion done,
>> which shapes the code in the way I see most suited for HEAD and
>> back-branches.
>
>
> Patch doesn't apply against HEAD.
>
> Also, don't we need more tests?
Oops. Sorry about that. v3 is incorrect, I messed up the origin commit
for the diffs generated. Here you go as attached.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| json_variadic_v4.patch | application/octet-stream | 26.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | gezeala | 2017-10-19 17:04:24 | BUG #14862: create table with missing sequence bug |
| Previous Message | Andrew Dunstan | 2017-10-19 13:13:41 | Re: BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-10-19 15:44:26 | Re: Supporting Windows SChannel as OpenSSL replacement |
| Previous Message | Tom Lane | 2017-10-19 14:53:30 | Re: Cursor With_Hold Performance Workarounds/Optimization |