| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | PostmasterPid not marked with PGDLLIMPORT |
| Date: | 2016-06-01 03:48:43 |
| Message-ID: | CAB7nPqS_=14KRCDcH6NyRsW8c58J1cwXv6QCVS7YP-6tTHQ1nA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi all,
While hacking a background worker for Windows/Linux that is sending
signals to the Postmaster depending on the state of the server where
Postgres is running (particularly after a certain size threshold is
reached on the partition of PGDATA SIGINT is sent to PostmasterPid to
have it stop cleanly), I have noticed that PostmasterPid is not marked
as PGDLLIMPORT in miscadmin.h, so I cannot use the field directly in
this background worker for Windows... Bypassing this problem can be
done by parsing postmaster.pid but adding this extra logic is really
annoying as this requires a one-line change upstream...
Could it be possible to mark PostmasterPid with PGDLLIMPORT on HEAD
and back-branches?
Regards,
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| mark-postpid-pgdllimport.patch | text/x-diff | 404 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2016-06-01 04:06:25 | Re: PostmasterPid not marked with PGDLLIMPORT |
| Previous Message | Tsunakawa, Takayuki | 2016-06-01 02:47:57 | Re: Question and suggestion about application binary compatibility policy |