| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Wang Hao <whberet(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Should buffer of initialization fork have a BM_PERMANENT flag |
| Date: | 2017-03-14 23:30:50 |
| Message-ID: | CAB7nPqSY7YNLqccXg7E2u-wkCVQEGx8Ln5hZatt9kaumsCcPBw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 15, 2017 at 1:13 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Mon, Mar 13, 2017 at 8:51 PM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
>>> I agree with that, but I propose the attached version instead. It
>>> seems cleaner to have the entire test for setting BM_PERMANENT in one
>>> place rather than splitting it up as you did.
>>
>> Fine for me. You may want to update the comment of BM_PERMANENT in
>> buf_internals.h as Artur has mentioned upthread. For example by just
>> adding "and init forks".
>
> OK, done, and back-patched all the way.
Thanks.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-03-14 23:34:12 | Re: WIP: Faster Expression Processing v4 |
| Previous Message | David Fetter | 2017-03-14 23:18:04 | Re: multivariate statistics (v25) |