| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>, sudalai <sudalait2(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: Index file got removed |
| Date: | 2016-11-24 02:34:13 |
| Message-ID: | CAB7nPqSS9+pVXFoW-WKp7NOep4usfR+3oDq3M3LoSdNbDmzLBw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Thu, Nov 24, 2016 at 8:31 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Thu, Nov 24, 2016 at 7:46 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> For instance, wouldn't it change the behavior of ALTER TABLE ADD
>> PRIMARY KEY?
>
> Good point. I forgot this one.
And I just wrote a test case breaking my previous patch, please see
attached. The idea is just to use ADD CONSTRAINT foo { PRIMARY KEY |
UNIQUE } and check if default_tablespace works as expected. Perhaps
that's worth having in the test suite? There is currently no coverage
regarding for index additions done with ALTER TABLE and tablespaces.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| alter-table-add-regression.patch | application/x-patch | 2.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | zmokdad | 2016-11-24 07:58:20 | BUG #14430: NPGSQL error |
| Previous Message | 张嘉志 | 2016-11-24 02:28:58 | Re: got some errors after upgrade poestgresql from 9.5 to 9.6 |