Re: Should buffer of initialization fork have a BM_PERMANENT flag

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Artur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>
Cc: Wang Hao <whberet(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: Should buffer of initialization fork have a BM_PERMANENT flag
Date: 2017-03-10 01:00:25
Message-ID: CAB7nPqSQCwbCsnB_W7uW85h3hytnX2TinwB=BZ8_RnB+CYMsbw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Mar 9, 2017 at 10:25 PM, Artur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> wrote:
> I think this is good fixes. I've checked them. And in my opinion they are
> correct.
>
> The code also is good.

Having something with conflicts is not nice, so attached is a rebased version.

> I have run regression and TAP tests. They all passed without error.
>
> I think the patch can be marked as "Ready for Committer" after rebase.

Thanks for the review.
--
Michael

Attachment Content-Type Size
unlogged-flush-fix-head-v2.patch application/octet-stream 7.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-03-10 01:01:08 Re: Re: [COMMITTERS] pgsql: Throw an error if a DATA() line contains wrong # of attributes.
Previous Message Michael Paquier 2017-03-10 00:53:55 Re: contrib modules and relkind check