Re: Patch to implement pg_current_logfile() function

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: "Karl O(dot) Pinc" <kop(at)meme(dot)com>
Cc: Gilles Darold <gilles(dot)darold(at)dalibo(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch to implement pg_current_logfile() function
Date: 2017-01-18 04:26:46
Message-ID: CAB7nPqSMyg6oOExES3Tfv1-7DzrioyR7-Ne3vF3JM_ane8N2Kg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Wed, Jan 18, 2017 at 11:36 AM, Karl O. Pinc <kop(at)meme(dot)com> wrote:
> On Wed, 18 Jan 2017 11:08:25 +0900
> Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote:
>
>> Our ideas rather map here, ERRCODE_INTERNAL_ERROR would be adapted for
>> this situation. Do any of you want to give it a shot or should I?
>
> You're welcome to it.

What do you think about that?
+ log_filepath = strchr(lbuffer, ' ');
+ if (log_filepath == NULL)
+ {
+ /*
+ * Corrupted data found, return NULL to the caller and still
+ * inform him on the situation.
+ */
+ ereport(WARNING,
+ (ERRCODE_INTERNAL_ERROR,
+ errmsg("corrupted data found in \"%s\"",
+ LOG_METAINFO_DATAFILE)));
+ break;
+ }

Recent commits 352a24a1 (not my fault) and e7b020f7 (my fault) are
creating conflicts, so a rebase was as well welcome.
--
Michael

Attachment Content-Type Size
patch_pg_current_logfile-v25.diff text/plain 15.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2017-01-18 04:33:35 Re: PoC: Grouped base relation
Previous Message Peter Eisentraut 2017-01-18 03:48:29 Re: Re: Clarifying "server starting" messaging in pg_ctl start without --wait