Re: Adding -E switch to pg_dumpall

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Adding -E switch to pg_dumpall
Date: 2017-07-15 09:15:12
Message-ID: CAB7nPqSA7OqpTmAGCMHbAGGn8kfsL0dO2HG7eejk5GOL5MNHcg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jul 14, 2017 at 12:39 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> While looking at a user problem, I got surprised that pg_dumpall does
> not have a -E switch. This has been discussed a bit in the past like
> here:
> https://www.postgresql.org/message-id/75E4C42D37E6A74E9FB57C2E9F1300D60107073E@tiger.nexperience.com
>
> Now it is possible to enforce the encoding used by using
> PGCLIENTENCODING but I think that a switch would be useful as well,
> particularly for Windows where "set" needs to be used. Are there any
> objections to a patch adding support for that? Such a patch should do:
> - Call PQsetClientEncoding if an encoding is defined after getting a connection.
> - Pass down -E to pg_dump calls if something is set.
>
> Thoughts?

Attached is a patch to add support for this switch. I am parking that
in the next CF.
--
Michael

Attachment Content-Type Size
pgdumpall-encoding-v1.patch application/octet-stream 3.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-07-15 15:22:37 Re: segfault in HEAD when too many nested functions call
Previous Message Michael Paquier 2017-07-15 08:25:43 Re: hash index on unlogged tables doesn't behave as expected