| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Nikolay Shaplov <n(dot)shaplov(at)postgrespro(dot)ru> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pageinspect patch, for showing tuple data |
| Date: | 2015-11-12 07:36:44 |
| Message-ID: | CAB7nPqS9UfrtSurNrRTn71s1bzMUQLvEVkVZ2CF7yS5VSquoKQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 12, 2015 at 9:04 AM, Michael Paquier wrote:
> On Thu, Nov 12, 2015 at 12:41 AM, Nikolay Shaplov wrote:
>> I still have an opinion that documentation should be more verbose, than your
>> version, but I can accept your version.
>
> I am not sure that's necessary, pageinspect is for developers.
>
>> Who is going to add heap_page_item_attrs to your patch? me or you?
>
> I recall some parts of the code I still did not like much :) I'll grab
> some room to have an extra look at it.
I have added back heap_page_item_attrs the patch attached, fixing at
the same time some typos found while looking again at the code. If you
are fine with this version, let's have a committer look at it.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 20151112_pageinspect_v5.patch | text/x-patch | 18.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2015-11-12 07:52:18 | Re: proposal: multiple psql option -c |
| Previous Message | Kyotaro HORIGUCHI | 2015-11-12 07:10:09 | Re: Foreign join pushdown vs EvalPlanQual |