Skip site navigation (1) Skip section navigation (2)

Re: VS 2015 support in src/tools/msvc

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: VS 2015 support in src/tools/msvc
Date: 2016-03-23 07:17:14
Message-ID: CAB7nPqS6JcQeFwurY4A9yznOaFv36NsoErfBQCGZNcShtU5OAw@mail.gmail.com (view raw, whole thread or download thread mbox)
Thread:
Lists: pgsql-hackers
On Mon, Mar 21, 2016 at 3:43 AM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
>
> On 03/20/2016 12:02 AM, Michael Paquier wrote:
>>
>> On Sun, Mar 20, 2016 at 8:06 AM, Andrew Dunstan <andrew(at)dunslane(dot)net>
>> wrote:
>>>
>>>
>>> Still to do: the non-perl pieces.
>>
>> The patch to address locales is the sensitive part. The patch from
>> Petr is taking the correct approach though I think that we had better
>> simplify it a bit and if possible we had better not rely on the else
>> block it introduces.
>
>
>
> OK, the please send an updated set of patches for what remains.

Here you go:
- 0001 fixes the global declarations of TIMEZONE_GLOBAL and
TZNAME_GLOBAL to be WIN32-compliant. I got bitten by that in the ECPG
compilation.
- 0002, support of VS2015 in the scripts of src/tools/msvc
- 0003, this is necessary in order to run the regression tests,
details are here:
http://www.postgresql.org/message-id/CAB7nPqTDiXxS8CdL8mOiVh6qFQ-1qV9mKN0AyjzYBvzv6WC0dA@mail.gmail.com
- 0004 is the fix for locales. This is actually Petr's work upthread,
I have updated comments in the code though and did a bit more
polishing. This still looks like the cleanest solution we have. Other
solutions are mentioned upthread: redeclaration of struct _locale_t in
backend code is one.
-- 
Michael

Attachment: 0001-Fix-declaration-of-TIMEZONE_GLOBAL-and-TZNAME_GLOBAL.patch
Description: binary/octet-stream (1.1 KB)
Attachment: 0002-Add-support-for-VS-2015-in-MSVC-scripts.patch
Description: binary/octet-stream (4.9 KB)
Attachment: 0003-Fix-non-compliant-boolean-declarations-with-stdbool.patch
Description: binary/octet-stream (18.5 KB)
Attachment: 0004-Fix-code-page-calculation-for-Visual-Studio-2015.patch
Description: binary/octet-stream (2.5 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Petr JelinekDate: 2016-03-23 07:27:06
Subject: Re: Proposal: Generic WAL logical messages
Previous:From: Amit KapilaDate: 2016-03-23 07:03:22
Subject: Re: Speed up Clog Access by increasing CLOG buffers

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group