Improving test coverage of extensions with pg_dump

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Improving test coverage of extensions with pg_dump
Date: 2015-03-03 05:40:21
Message-ID: CAB7nPqRx=zmBFJyjrWhGuhHqK__8M+wd+P95ceNJtMHxXR7RRg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,

While investigating the issue that has been committed as ebd092b to
fix FK dependencies in pg_dump for tables in extensions, I developed a
small test case aimed for integration in src/test/modules to ensure
that this does not break again in the future. Note that as the
regression tests of this test module use TAP tests to run a set of
pg_dump commands and check the sanity of FK dependency tracking with
extensions, this has needed a one-line tweak of the target prove_check
to be able to install the contents of the current directory to the
temp install folder before running the tests.

I imagine that it would be nice to integrate this test case to improve
test coverage of pg_dump, extending at the same time TAP support for
extensions, so attached are patches for this purpose.

Those patches are really simple, but then perhaps there are better or
simpler ways than what is attached, so feel free to comment if you
have any ideas.
Regards,
--
Michael

Attachment Content-Type Size
0001-Make-prove_check-install-contents-of-current-directo.patch application/x-patch 1.1 KB
0002-Add-dump_test-test-module-to-check-pg_dump-with-exte.patch application/x-patch 5.1 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2015-03-03 07:25:35 Re: Patch: raise default for max_wal_segments to 1GB
Previous Message Arthur Silva 2015-03-03 03:08:12 Re: Abbreviated keys for text cost model fix