| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Asim Praveen <apraveen(at)pivotal(dot)io> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Jacob Champion <pchampion(at)pivotal(dot)io>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Kevin Grittner <kgrittn(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Assert that the correct locks are held when calling PageGetLSN() |
| Date: | 2017-11-09 02:12:49 |
| Message-ID: | CAB7nPqRKdnOyp4AiWptdufOVv5MWDzi5PA0AQMqrOtM=-PUHgw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 9, 2017 at 8:25 AM, Asim Praveen <apraveen(at)pivotal(dot)io> wrote:
> Indeed, the assertion tripped during WAL replay on the standby. This was
> caught by TAP tests under src/test/recovery. The assertion is now fixed so
> that WAL replay is exempt from the check. Please find the new patch
> attached. The tests now pass with the fix. I also manually verified that
> recovery works with "wal_consistency_checking=all".
I still have a bad feeling about that bit... Still, it does not change
the fact that patch 0001 in
https://www.postgresql.org/message-id/CANXE4TccH_VjdKaHc9=KyH0Y7WORqZN+=mH5f=mP0Bw3gzX1Sw@mail.gmail.com
needs a committer per the fact that it visibly fixes incorrect backend
code and API contract. So I am switching the CF entry to ready for
committer, but only for 0001.
The other things could always be taken care of later.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2017-11-09 03:15:51 | Re: Hang in pldebugger after git commit : 98a64d0 |
| Previous Message | Michael Paquier | 2017-11-09 02:09:20 | Re: [PATCH] A hook for session start |