| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Subject: | Re: Error while copying a large file in pg_rewind |
| Date: | 2017-07-22 05:50:29 |
| Message-ID: | CAB7nPqRD=QcLwB0b88KtYmUYyWkLJB_jCQPGnZ7BT8pnkQC-6A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 21, 2017 at 8:22 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Thu, Jul 20, 2017 at 9:31 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> Still, it can't be worse than the status quo, where instead of int64
>> we're using int and int32, so maybe we ought to back-patch it as-is
>> for now and look at any further cleanup that is needed as a
>> master-only improvement.
>
> Yes. I don't like playing much with the variable types on
> back-branches, as long as the initial amount of bytes is large enough
> we will be safe for some time.
Note for the archives: the main issue has been fixed as a46fe6e8, and
the incorrect condition as 063ff921. Thanks Robert!
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-07-22 14:50:16 | Re: Syncing sql extension versions with shared library versions |
| Previous Message | Robert Haas | 2017-07-22 02:10:27 | pgsql: pg_rewind: Fix some problems when copying files >2GB. |