Re: [JDBC] [HACKERS] Channel binding support for SCRAM-SHA-256

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Álvaro Hernández Tortosa <aht(at)8kdata(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [JDBC] [HACKERS] Channel binding support for SCRAM-SHA-256
Date: 2017-12-22 08:10:30
Message-ID: CAB7nPqR0ueQk5mtcZncDLacF3uat18SJR_U=qQHnhXvGHer8ug@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-jdbc

On Fri, Dec 22, 2017 at 11:59 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> I have looked at how things could be done in symmetry for both the frontend
> and backend code, and I have produced the attached patch 0002, which
> can be applied on top of 0001 implementing tls-server-end-point. This
> simplifies the interfaces to initialize the SCRAM status data by saving
> into scram_state and fe_scram_state respectively Port* and PGconn* which
> holds most of the data needed for the exchange. With this patch, cbind_data
> is generated only if a specific channel binding type is used with the
> appropriate data. So if no channel binding is used there is no additional
> SSL call done to get the TLS finished data or the server certificate hash.
>
> 0001 has no real changes compared to the last versions.

Second thoughts on 0002 as there is actually no need to move around
errorMessage if the PGconn* pointer is saved in the SCRAM status data
as both are linked. The attached simplifies the logic even more.
--
Michael

Attachment Content-Type Size
0001-Implement-channel-binding-tls-server-end-point-for-S.patch text/x-patch 17.0 KB
0002-Refactor-channel-binding-code-to-fetch-cbind_data-on.patch text/x-patch 27.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2017-12-22 08:16:10 Re: pgsql: Add parallel-aware hash joins.
Previous Message Teodor Sigaev 2017-12-22 07:53:46 Re: genomic locus

Browse pgsql-jdbc by date

  From Date Subject
Next Message Peter Eisentraut 2017-12-26 20:28:09 Re: [JDBC] [HACKERS] Channel binding support for SCRAM-SHA-256
Previous Message Michael Paquier 2017-12-22 02:59:08 Re: [JDBC] [HACKERS] Channel binding support for SCRAM-SHA-256