Re: Perl coding error in msvc build system?

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Brar Piening <brar(at)gmx(dot)de>, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>
Subject: Re: Perl coding error in msvc build system?
Date: 2015-02-18 06:44:04
Message-ID: CAB7nPqQvXKwKDoFkAsPG-OiW2PuoDiDTpmYCR_gze3drQtmmYQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Tue, Feb 17, 2015 at 6:34 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>> This patch been reviewed by 4 people, resulting in 2 minor suggestions
>> for changes (adding an m modifier, and removing a bogus last).
>>
>> It has 2 clear upvotes and 0 downvotes.
>>
>> I think it should be revised along the lines suggested and committed
>> without further ado.
>
> My patch actually only covered the first of the two faulty locations I
> pointed out. Attached is a patch that also fixes the second one. I
> noticed that DetermineVisualStudioVersion() is never called with an
> argument, so I removed that branch altogether.

+1 for those simplifications. And FWIW, it passed my series of tests
with MSVC 2010.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kouhei Kaigai 2015-02-18 08:13:10 Re: Combining Aggregates
Previous Message Michael Paquier 2015-02-18 06:26:50 Re: Strange assertion using VACOPT_FREEZE in vacuum.c