Re: Crash on promotion when recovery.conf is renamed

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Magnus Hagander <magnus(at)hagander(dot)net>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Crash on promotion when recovery.conf is renamed
Date: 2017-09-02 12:17:11
Message-ID: CAB7nPqQqwARXPGX2AHP-9rkuUyTEu=y48vJe2X7d_N=Jqua_wQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Fri, Sep 1, 2017 at 7:17 PM, Thomas Munro
<thomas(dot)munro(at)enterprisedb(dot)com> wrote:
> On Sat, Aug 26, 2017 at 7:32 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Sat, Apr 8, 2017 at 10:05 AM, David Steele <david(at)pgmasters(dot)net> wrote:
>>> On 3/28/17 1:21 AM, Tsunakawa, Takayuki wrote:
>>>> Thanks, marked as ready for committer, as the code is good and Alexander reported the test success.
>>>
>>> This bug has been moved to CF 2017-07.
>>
>> This bug fix has been pending in "Ready for Committer" state for about
>> 4.5 months. Three committers (Magnus, Heikki, Tom) have contributed
>> to the thread to date. Maybe one of them would like to commit this?
>
> In the meantime its bits have begun to rot. Michael, could you please rebase?

Thanks for the reminder, Thomas. The 2PC code triggered during
recovery has been largely reworked in PG10, explaining the conflicts.
As this has been some time since I touched this patch, I had again a
look at its logic and could not find any problems around it. So
attached are a rebased versions for both 0001 and 0002, I have updated
the messages as well to be more in-line with what is in HEAD for
corrupted entries.
--
Michael

Attachment Content-Type Size
0002-Minimize-window-between-history-file-and-end-of-reco.patch text/x-patch 2.7 KB
0001-Change-detection-of-corrupted-2PC-files-as-FATAL.patch text/x-patch 3.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2017-09-02 12:30:54 Re: Parallel worker error
Previous Message David Steele 2017-09-02 12:15:45 Re: Rename RECOVERYXLOG to RECOVERYWAL?