| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Rahila Syed <rahilasyed(dot)90(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [REVIEW] Re: Compression of full-page-writes |
| Date: | 2014-11-26 08:25:18 |
| Message-ID: | CAB7nPqQnqzcuwrZuUtktwarYBUFYRs8eExYwXQMvPrLYE92_LQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
So, Here are reworked patches for the whole set, with the following changes:
- Found why replay was failing, xlogreader.c took into account BLCKSZ
- hole while it should have taken into account the compressed data
length when fetching a compressed block image.
- Reworked pglz portion to have it return status errors instead of
simple booleans. pglz stuff is as well moved to src/common as Alvaro
suggested.
I am planning to run some tests to check how much compression can
reduce WAL size with this new set of patches. I have been however able
to check that those patches pass installcheck-world with a standby
replaying the changes behind. Feel free to play with those patches...
Regards,
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Move-pg_lzcompress.c-to-src-common.patch | text/x-patch | 52.2 KB |
| 0002-Support-compression-for-full-page-writes-in-WAL.patch | text/x-patch | 33.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2014-11-26 08:58:28 | Re: [pgsql-packagers] Palle Girgensohn's ICU patch |
| Previous Message | bouda | 2014-11-26 08:10:59 | BUG #12070: hstore extension: hstore_to_json_loose produces invalid JSON |