| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Amir Rohan <amir(dot)rohan(at)zoho(dot)com> |
| Cc: | Amir Rohan <amir(dot)rohan(at)mail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, gsmith(at)gregsmith(dot)com |
| Subject: | Re: In-core regression tests for replication, cascading, archiving, PITR, etc. |
| Date: | 2015-10-04 11:03:32 |
| Message-ID: | CAB7nPqQk6N6J4_9OLfFfsMs9FRoK7exGOC6PNp7caLqFTzZ-Qg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Oct 3, 2015 at 10:47 PM, Michael Paquier wrote:
> On Sat, Oct 3, 2015 at 9:50 PM, Amir Rohan wrote:
>>>> Block until recovery is finished, before testing. eliminate races, and
>>>> avoid the stupid sleep(3) I used.
>>>
>>> TODO
>
> Well. I just recalled this item in the list of things you mentioned. I
> marked it but forgot to address it. It sounds right that we may want
> something using pg_isready in a loop as a node in recovery would
> reject connections.
I just hacked up an updated version with the following things:
- Optional argument for stop_node to define the stop mode of pg_ctl
- Addition of wait_for_node where pg_isready is used to wait until a
node is ready to accept queries
- Addition of a local lookup variable to track the last port assigned.
This accelerates get_free_port.
Regards,
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 20151004_recovery_regressions_v6.patch | text/x-patch | 29.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shay Rojansky | 2015-10-04 12:50:10 | Re: Odd query execution behavior with extended protocol |
| Previous Message | Pavel Stehule | 2015-10-04 10:50:25 | Re: check fails on Fedora 23 |