Re: pg_basebackup fails on Windows when using tablespace mapping

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>
Cc: nb <nbedxp(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_basebackup fails on Windows when using tablespace mapping
Date: 2017-06-27 13:06:42
Message-ID: CAB7nPqQiBr+_S0A36DnrZB2Ms-zVAb5=8B78+m2HNPa=xztnDQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Tue, Jun 27, 2017 at 7:46 PM, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> wrote:
> I am still seeing the issue with the attached patch. I had a quick
> look into the patch. It seems to me like you have canonicalized the
> tablespace path to convert win32 slashes to unix type of slashes but
> that is not being passed to strcmp() function and probably that could
> be the reason why the issue is still existing. Thanks.
>
> for (cell = tablespace_dirs.head; cell; cell = cell->next)
> - if (strcmp(dir, cell->old_dir) == 0)
> + if (strcmp(canon_dir, cell->old_dir) == 0)

Thanks. I had the correct version on my Windows box actually, just
messed up the attachment.
--
Michael

Attachment Content-Type Size
basebackup-win-tbspace-v2.patch text/x-patch 1.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2017-06-27 13:08:41 Re: Pluggable storage
Previous Message Yugo Nagata 2017-06-27 12:03:13 Re: pg_terminate_backend can terminate background workers and autovacuum launchers