| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | Petr Jelinek <petr(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Adrien Nayrat <adrien(dot)nayrat(at)dalibo(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Christoph Berg <myon(at)debian(dot)org>, Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com> |
| Subject: | Re: LSN as a recovery target |
| Date: | 2016-08-24 04:50:43 |
| Message-ID: | CAB7nPqQZpQVKPp6vvoqeUayaMDba=hgTbM370S7q_Kjz7U5u7A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 23, 2016 at 8:50 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Tue, Aug 23, 2016 at 6:10 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>> On 23 August 2016 at 09:39, Petr Jelinek <petr(at)2ndquadrant(dot)com> wrote:
>>
>>> Looks very reasonable to me (both patches). Thanks for doing that.
>>>
>>> I am inclined to mark this as ready for committer.
>>
>> Looking at it now.
>>
>> The messages for recovery_target_lsn don't mention after or before, as
>> do other targets... e.g.
>> recoveryStopAfter ? "after" : "before",
>> My understanding is that if you request an LSN that isn't the exact
>> end point of a WAL record then it will either stop before or after the
>> requested point, so that needs to be described in the docs and in the
>> messages generated prior to starting to search.
>>
>> Everything else looks in good order.
>
> You are right, this message should be completed as such. Do you want
> an updated patch?
Well, I finished by updating the patch anyway.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Introduce-recovery_target_lsn-in-recovery.conf.patch | invalid/octet-stream | 11.9 KB |
| 0002-Introduce-error-callback-when-parsing-recovery.conf.patch | invalid/octet-stream | 2.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Kirkwood | 2016-08-24 04:52:27 | Re: Write Ahead Logging for Hash Indexes |
| Previous Message | Amit Kapila | 2016-08-24 04:33:19 | Re: Write Ahead Logging for Hash Indexes |