Re: [HACKERS] subscription worker signalling wal writer too much

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] subscription worker signalling wal writer too much
Date: 2017-11-28 01:46:06
Message-ID: CAB7nPqQXTLzVtuTozyuiTDfB30iGrBPoeCJMXKuD-J2Lopn4jA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Tue, Nov 21, 2017 at 3:44 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> I have just gone through this thread, and reducing the amount of times
> the WAL writer is woken up is something worth doing. The last version
> if v3 that Robert has sent in
> https://www.postgresql.org/message-id/CA+TgmoZhw_nyrxYUqSuDh-XEJya-YzfwShki5NuDS=UfgvodrA@mail.gmail.com.
> As far as I can see, the smarter formula presented here comes from
> XLogBackgroundFlush(). Jeff, could you update the patch to reflect
> that the new condition you are adding comes from there? I am switching
> the patch as "waiting on author" for now.

It has been one week since this update, in consequence I am marking
this patch as returned with feedback for now. Please make sure to
register a new CF entry if you can get a new version out.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2017-11-28 01:48:28 Re: [HACKERS] VACUUM and ANALYZE disagreeing on what reltuples means
Previous Message Michael Paquier 2017-11-28 01:43:10 Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki