Re: extend pgbench expressions with functions

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Tomáš Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: extend pgbench expressions with functions
Date: 2015-12-16 05:54:57
Message-ID: CAB7nPqQUeu9nWfbPHymFKeJykDA3H-Ako0F7d9wwfFwbtbRC+g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Dec 16, 2015 at 6:10 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Mon, Dec 14, 2015 at 7:25 AM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote:
>> I have looked for now at the first patch and finished with the
>> attached while looking at it. Perhaps a committer could look already
>> at that?
>
> It looks fine to me except that I think we should spell out "param" as
> "parameter" throughout, instead of abbreviating.

Fine for me. I have updated the first patch as attached (still looking
at the second).
--
Michael

Attachment Content-Type Size
0001-Make-pgbench-documentation-more-precise-for-function.patch binary/octet-stream 13.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jon Erdman 2015-12-16 05:57:59 Re: Logical replication and multimaster
Previous Message Haribabu Kommi 2015-12-16 05:11:46 Re: Parallel Aggregate