Re: BUG #14866: The generated constraint in the typed table causes the server to crash

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, gomer94(at)yandex(dot)ru, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>
Subject: Re: BUG #14866: The generated constraint in the typed table causes the server to crash
Date: 2017-11-11 09:11:06
Message-ID: CAB7nPqQTFdN8=Nk7=XNhH5uJPngCC88z-XEZ8tnTWqqVjRM8iA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-bugs

On Fri, Nov 10, 2017 at 11:33 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> All in all, I would be more on board with just issuing errors when
> trying to attempt typed table creation with identity columns and
> partitions for now, by complaining with a
> ERRCODE_FEATURE_NOT_SUPPORTED. Any person willing to add this support
> later on could always provide a patch for it, I am now rather
> convinced that what I proposed upthread is not the correct way to do
> so, and there is no rush in implementing it correctly for v11 or even
> later.
>
> Peter, Robert, Amit, thoughts?

And this gives the attached. That still looks like the safest thing to
do for now on v10 and HEAD after more thoughts.
--
Michael

Attachment Content-Type Size
tab-identity-crashes-v3.patch text/x-patch 3.7 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Dmitry Dolgov 2017-11-11 10:34:09 Re: BUG #14897: Segfault on statitics SQL request
Previous Message Michael Paquier 2017-11-11 08:39:11 Re: BUG #14897: Segfault on statitics SQL request