Re: [HACKERS] [PATCH] Add recovery_min_apply_delay_reconnect recovery option

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Eric Radman <ericshane(at)eradman(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Simon Riggs <simon(at)2ndquadrant(dot)com>
Subject: Re: [HACKERS] [PATCH] Add recovery_min_apply_delay_reconnect recovery option
Date: 2017-11-15 08:08:42
Message-ID: CAB7nPqQ4wCTF0vBF0ug6=_6_gXM7NYxkNJ9a8vaitjEvgkzcZA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 20, 2017 at 3:46 AM, Eric Radman <ericshane(at)eradman(dot)com> wrote:
> On Tue, Oct 17, 2017 at 12:34:17PM +0900, Michael Paquier wrote:
>> On Tue, Oct 17, 2017 at 12:51 AM, Eric Radman <ericshane(at)eradman(dot)com> wrote:
>> > This administrative compromise is necessary because the WalReceiver is
>> > not resumed after a network interruption until all records are read,
>> > verified, and applied from the archive on disk.
>>
>> I see what you are trying to achieve and that seems worth it. It is
>> indeed a waste to not have a WAL receiver online while waiting for a
>> delay to be applied.
> ...
>> If you think about it, no parameters are actually needed. What you
>> should try to achieve is to make recoveryApplyDelay() smarter,
>
> This would be even better. Attached is the 2nd version of this patch
> that I'm using until an alternate solution is developed.

I definitely agree that a better handling of WAL receiver restart
would be done, however this needs and a better-thought refactoring
which is not this patch provides, so I am marking it as returned with
feedback. People looking for a solution, and not using archiving
(because your patch breaks it), could always apply what you have as a
workaround.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2017-11-15 08:09:58 Re: [HACKERS] Transform for pl/perl
Previous Message Michael Paquier 2017-11-15 07:13:01 Re: [HACKERS] More stats about skipped vacuums