|From:||Michael Paquier <michael(dot)paquier(at)gmail(dot)com>|
|To:||PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Coverage improvements of src/bin/pg_basebackup and pg_receivewal --endpos|
|Views:||Raw Message | Whole Thread | Download mbox|
The coverage of pg_basebackup is reaching 50%, which is not bad:
In this set pg_receivewal.c is the bad student with less than 20%.
There are a couple of causes behind that, with no tests like:
- option interactions like --create-slot and --drop-slot.
- replication slot drop.
- end of streaming.
- check handling of history files.
- looking at compressed and uncompressed WAL data.
- restart of pg_receivewal on an existing folder.
- pg_basebackup's tests don't use the progress report.
While it is possible to tackle some of those issues independently,
like pg_basebackup stuff, it seems to me that it would be helpful to
make the tests more deterministic by having an --endpos option for
pg_receivewal, similarly to what exists already in pg_recvlogical.
|Next Message||Amit Langote||2017-06-07 00:30:14||Re: sketchy partcollation handling|
|Previous Message||Peter Geoghegan||2017-06-07 00:19:28||Re: PG10 transition tables, wCTEs and multiple operations on the same table|