| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_dump, pg_dumpall and data durability |
| Date: | 2016-11-08 00:52:27 |
| Message-ID: | CAB7nPqQ+fzsCGeE2dqN+275JeSGEBFSBp7Oau+tX4ckiz-=bjg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 8, 2016 at 1:24 AM, Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at> wrote:
> The patch does not apply, I had to change the hunk for
> src/include/common/file_utils.h.
Yes, the patch has rotten a bit because of f82ec32a. 5d58c07a has also
made the --noxxx option names appearing as --no-xxx.
> Also, compilation fails because function "pre_fsync_fname" cannot be
> resolved during linking. Is that a typo for "pre_fsync_fname" or is
> the patch incomplete?
A typo s/pre_fsync_fname/pre_sync_fname, and a mistake from me because
I did not compile with -DPG_FLUSH_DATA_WORKS to check this code.
v2 is attached, fixing those issues.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| pgdump-sync-v2.patch | text/x-patch | 13.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-11-08 01:33:28 | Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled |
| Previous Message | Michael Paquier | 2016-11-08 00:25:46 | Re: add more NLS to bin |